-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closing the gaps in Texpr generation #1700
Conversation
First evaluations of expr conversions on the bench/coreutils folder revealed the following conversion success/failure stats: cp:
cksum:
Overall, my worries, that overflow-treatment and non-injective assignments would stop the show seem not to be the major issue in these examples. I am curious how far we can push the success rate. A few first steps:
More long-term thoughts:
|
After replacing the raised exception in the conversion's queryInt with a returned top, we could immediately gain roughly 10 points success percentage for both cases, eg. for cksum:
The other data does not immediately suggest any other changes imho, so I would consider this the only change for now. |
In this PR, I want to fine-tune the expression conversion that is happening in
sharedFunctions.apron.ml
to cover more expressions, letting all affeqesque domains benefit from more precise information.export lines=$(grep "rel-texpr-cil-conv" /tmp/goblintlog.txt | wc -l) ; cat /tmp/goblintlog.txt | grep "rel-texpr-cil-conv" | sed 's/(/ /g' | awk \{print\ \$5\ \$g\} | sort | uniq -c | sort -k 1,1 -rn | awk {print\ \$1*100/$lines\ \"%\ \"\ \$2}